add dependencies to setup.py, remove numpy2.0 install dep #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install_deps. remove coilpy as a dep since distutils is deprecated.
|
Can you replace the deprecated |
|
@mbkumar The python build system is something that I still have to learn about, excuse my ignorance. Can I rely on your expertise for some help? I have the following questions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Utilities do not need python2.0 as an install dependency, as they have no binary interface.
Also the requirements are better specified in setup.py than requirements.txt (simsopt ci manually installs requirements.txt, so leaving the file for now...).
We should update the build system at some point, setup.py is deprecated and it is a matter of time before it fails.
@mbkumar do you foresee any issues in simsopt CI with the removal of numpy versioning?